Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: efe0051a9d78
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 90c0191735bc
Choose a head ref
  • 5 commits
  • 1 file changed
  • 2 contributors

Commits on Apr 17, 2020

  1. systemd: Simplify unit script names 

    Current journal output from services started by `script` rather than
`ExexStart` is unreadable because the name of the file (which journalctl
records and outputs) quite literally takes 1/3 of the screen (on smaller
screens).

Make it shorter. In particular:

* Drop the `unit-script` prefix as it is not very useful.
* Use `writeShellScriptBin` to write them because:
  * It has a `checkPhase` which is better than no checkPhase.
  * The script itself ends up having a short name.
    @kirelagin
    kirelagin committed Apr 17, 2020
    Copy the full SHA
    5822d03 View commit details
    Browse the repository at this point in the history

  2. fixup! systemd: Simplify unit script names

    @kirelagin
    kirelagin committed Apr 17, 2020
    Copy the full SHA
    f1a78e1 View commit details
    Browse the repository at this point in the history

  3. systemd: Add prefix to unit script derivations 

    Add a distinctive `unit-script` prefix to systemd unit scripts to make
them easier to find in the store directory. Do not add this prefix to
actual script file name as it clutters logs.
    @kirelagin
    kirelagin committed Apr 17, 2020
    Copy the full SHA
    a9e9d37 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2020

  1. fixup! systemd: Add prefix to unit script derivations 

    * Avoid extra string interpolation.
    @kirelagin
    kirelagin committed Apr 20, 2020
    Copy the full SHA
    daac85d View commit details
    Browse the repository at this point in the history

Commits on May 12, 2020

  1. Merge pull request #85428 from serokell/kirelagin/unit-script-name 

    systemd: Simplify unit script names
    @lheckemann
    lheckemann committed May 12, 2020
    Copy the full SHA
    90c0191 View commit details
    Browse the repository at this point in the history