Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glpaper: init at unstable-2020-03-30 #87689

Closed
wants to merge 1 commit into from
Closed

glpaper: init at unstable-2020-03-30 #87689

wants to merge 1 commit into from

Conversation

ccellado
Copy link
Contributor

@ccellado ccellado commented May 12, 2020 •
edited

Motivation for this change

Add new useful package to the Wayland stack.

Things done

Added glpaper package.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jtojnar
jtojnar reviewed May 12, 2020
View reviewed changes
pkgs/development/tools/glpaper/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/glpaper/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/glpaper/default.nix Outdated Show resolved Hide resolved
@ccellado ccellado changed the title glpaper -> add glpaper: init at a95db77088df May 12, 2020
@ccellado
Copy link
Contributor Author

Added myself to maintainers list.

@ccellado ccellado requested a review from jtojnar May 14, 2020 16:04
@ccellado
Copy link
Contributor Author

@jtojnar Anything else?

jtojnar
jtojnar reviewed May 16, 2020
View reviewed changes
pkgs/development/tools/glpaper/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/glpaper/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/glpaper/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/glpaper/default.nix Outdated Show resolved Hide resolved
@taikatytto
glpaper: init at unstable-2020-03-30
4d00d0a 
	modified:   maintainers/maintainer-list.nix
	new file:   pkgs/development/tools/glpaper/default.nix
	modified:   pkgs/top-level/all-packages.nix
@ccellado ccellado requested a review from adisbladis as a code owner May 16, 2020 15:49
ccellado
ccellado commented May 16, 2020
View reviewed changes
Copy link
Contributor Author

@ccellado ccellado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Messed up my commits when squashed them, how to remove there ones?

@ccellado ccellado changed the title glpaper: init at a95db77088df glpaper: init at unstable-2020-03-30 May 16, 2020
@ccellado
Copy link
Contributor Author

Got mixed up branches, recreated cleanly at #87953

Sorry for the inconvenience.

@ccellado ccellado closed this May 16, 2020
@ccellado ccellado deleted the glpaper branch May 16, 2020 16:06
@jtojnar
Copy link
Contributor

jtojnar commented May 16, 2020

In the future, you can use git reset --hard commit to change branch to point to a different commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
6.topic: emacs 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ccellado @jtojnar @taikatytto