Skip to content

terminal_tarot: init at 0.1.1 #87688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

terminal_tarot: init at 0.1.1 #87688

wants to merge 1 commit into from
+33 −0

Conversation

aswan89
Copy link

@aswan89 aswan89 commented May 12, 2020

Motivation for this change

Adding a new toy application to the repository.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Lassulus
Copy link
Member

needs a rebase

@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
@aswan89 aswan89 force-pushed the add_terminal_tarot branch from e153859 to 7113ce1 Compare October 12, 2020 19:55
@aswan89 aswan89 changed the title terminal_tarot: init at 0.1.0 terminal_tarot: init at 0.1.1 Oct 12, 2020
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 12, 2020
ryantm
ryantm requested changes Oct 31, 2020
View reviewed changes
pkgs/tools/misc/terminal_tarot/default.nix

rustPlatform.buildRustPackage rec {
pname = "terminal_tarot";
version = "v0.1.1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't typically put the v into the version. You can just put it in the rev part...

pkgs/tools/misc/terminal_tarot/default.nix

rustPlatform.buildRustPackage rec {
pname = "terminal_tarot";
version = "v0.1.1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "v0.1.1";
version = "0.1.1";

pkgs/tools/misc/terminal_tarot/default.nix
src = fetchFromGitHub {
owner = "aswan89";
repo = pname;
rev = version;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = version;
rev = "v${version};

pkgs/tools/misc/terminal_tarot/default.nix
meta = with stdenv.lib; {
description = "Toy application for making tarot readings at the terminal, Written in Rust";
homepage = "https://github.com/aswan89/terminal_tarot";
license = licenses.gpl3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license = licenses.gpl3;
license = licenses.gpl3Only;

The gpl license variants without the Plus or Only suffix are deprecated, because they do not specify the license well enough. Use Plus if the project has "or later" sections in the actual source code files (not the license). Otherwise, use the Only suffix.

See https://discourse.nixos.org/t/lib-licenses-gpl3-co-are-now-deprecated/8206 for more details.

@ryantm
Copy link
Member

ryantm commented Oct 31, 2020

Result of nixpkgs-review pr 87688 1

1 package built:
- terminal_tarot

@SuperSandro2000
Copy link
Member

@aswan89 friendly ping

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 87688 run on x86_64-darwin 1

1 package built:
  • terminal_tarot

@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@SuperSandro2000
Copy link
Member

Closing due to inactivity from author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aswan89 @Lassulus @ryantm @SuperSandro2000