Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kicad: 5.1.5 -> 5.1.6 #87656

Merged
merged 2 commits into from May 21, 2020
Merged

kicad: 5.1.5 -> 5.1.6 #87656

merged 2 commits into from May 21, 2020

Conversation

evils
Copy link
Member

@evils evils commented May 12, 2020

Motivation for this change

a new stable release was tagged

Things done

bump stable to 5.1.6
bump unstable to latest revs

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • 5.1.5 was 6344919344 (1107596784 on hydra), 5.1.6 is 6540520616 (1114545504 on hydra)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@evils evils marked this pull request as draft May 12, 2020 11:49
@evils evils marked this pull request as ready for review May 12, 2020 12:06
@wucke13
Copy link
Contributor

wucke13 commented May 12, 2020

LGTM. Compiles on NixOS 20.03.

@bjornfor bjornfor merged commit d798396 into NixOS:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evils @wucke13 @bjornfor