Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qutebrowser: 1.10.0 -> 1.11.1 #87701

Merged
merged 3 commits into from May 13, 2020

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented May 12, 2020

Motivation for this change

fixes CVE-2020-11054
"backport" of #87671

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @bjornfor

(cherry picked from commit 1619ec9)
@bjornfor
Copy link
Contributor

Does this mean moving from 1.10 to 1.11 on the stable branch is too much? (If it's acceptible, it seems like the simpler way: just cherry-pick straight from master.)

@rnhmjoj
Copy link
Contributor

rnhmjoj commented May 13, 2020

I'd say to simply cherry-pick the update to 1.11. From the changelog there are only a few minor incompatibilities but much more fixes.

paumr and others added 2 commits May 13, 2020 18:59
(cherry picked from commit 4a5b853)
fixes CVE-2020-11054

(cherry picked from commit 52fcfd3)
@dotlambda dotlambda changed the title qutebrowser: 1.10.0 -> 1.10.2 qutebrowser: 1.10.0 -> 1.11.1 May 13, 2020
@bjornfor bjornfor merged commit c3e2cbf into NixOS:release-20.03 May 13, 2020
@dotlambda dotlambda deleted the qutebrowser-1.10.2 branch May 14, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants