Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgnurl: reduce size of closure. Remove unnecessary/old dependencies, #87685

Merged
merged 1 commit into from Aug 27, 2021
Merged

libgnurl: reduce size of closure. Remove unnecessary/old dependencies, #87685

merged 1 commit into from Aug 27, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 12, 2020

use python3, remove groff, remove nghttp2.

Motivation for this change

Reduction of closure size for gnurl and dependent packages

Things done

I haven't tested this, but I am the maintainer of the software and I have packaged it for various package managers, actively maintain the pkgsrc port of it.
Note: you might want to test moving the perl dependency to the tests phase (as far as I am aware only running tests requires perl, and if it's not detected some things are skipped), and you might want to add py-impacket to the tests phase as it has been removed in-tree.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from vrthra May 12, 2020 17:11
@stale
Copy link

stale bot commented Nov 8, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 8, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 18, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 87685 run on x86_64-linux 1

2 packages built:
  • gnunet
  • libgnurl

@tomberek
Copy link
Contributor

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 87685 run on x86_64-linux 1

1 package failed to build and are new build failure:
  • gnunet-gtk: log was empty
2 packages built:
  • gnunet
  • libgnurl

@stale
Copy link

stale bot commented Aug 24, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 24, 2021
@tomberek
Copy link
Contributor

Result of nixpkgs-review pr 87685 run on x86_64-linux 1

3 packages built:
  • gnunet
  • gnunet-gtk
  • libgnurl

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 27, 2021
@tomberek tomberek merged commit 59b3fb4 into NixOS:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrthra vrthra Awaiting requested review from vrthra

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @tomberek