Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/manual: document use of systemd to mount filesystems #87684

Merged
merged 2 commits into from May 14, 2020
Merged

nixos/manual: document use of systemd to mount filesystems #87684

merged 2 commits into from May 14, 2020

Conversation

glasserc
Copy link
Contributor

Motivation for this change

Fixes #87291.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc @flokli

@glasserc glasserc changed the title nixos/manual: Document use of systemd to mount filesystems nixos/manual: document use of systemd to mount filesystems May 12, 2020
flokli
flokli requested changes May 13, 2020
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up! Suggested something explaining what does what here, PTAL.

nixos/doc/manual/configuration/file-systems.xml Outdated Show resolved Hide resolved
@flokli flokli merged commit b59b741 into NixOS:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli requested changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mount points are not created automatically on nixos-rebuild switch
2 participants
@glasserc @flokli