Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asciidoctor: fix dangling ascidoctor-safe symlink #87646

Merged
merged 1 commit into from Sep 19, 2020
Merged

asciidoctor: fix dangling ascidoctor-safe symlink #87646

merged 1 commit into from Sep 19, 2020

Conversation

evils
Copy link
Member

@evils evils commented May 12, 2020 •
edited

as such a binary does not appear to be in the gem

Motivation for this change

i'm getting a warning about this seemingly every time i do anything with nix-env

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
nix-review pr 87646 
1 package marked as broken and skipped:
far2l

2 packages blacklisted:
tests.nixos-functions.nixos-test tests.nixos-functions.nixosTest-test

2 packages failed to build:
almanah rabbitvcs

118 packages built:
Sylk adapta-gtk-theme appimage-run asciidoctor atom atom-beta awesome bat-extras.batgrep btrbk calls cantata chrome-gnome-shell cinnamon.cinnamon-control-center clementine clementineUnfree deepin.dde-file-manager deepin.startdde deja-dup deltachat-electron dropbox-cli elementary-planner empathy esh evolution-data-server feedreader folks gfbgraph gnome-multi-writer gnome-online-accounts gnome-photos gnome-recipes gvfs gnome3.bijiben gnome3.cheese gnome3.evolution gnome3.file-roller gnome3.geary gnome3.gnome-applets gnome3.gnome-books gnome3.gnome-boxes gnome3.gnome-calendar gnome3.gnome-contacts gnome3.gnome-control-center gnome3.gnome-disk-utility gnome3.gnome-documents gnome3.gnome-flashback gnome3.gnome-initial-setup gnome3.gnome-maps gnome3.gnome-music gnome3.gnome-online-miners gnome3.gnome-panel gnome3.gnome-session gnome3.gnome-shell gnome3.gnome-software gnome3.gnome-terminal gnome3.gnome-todo gnome3.gnome-tweaks gnome3.gnome-user-share grilo-plugins gnome3.gvfs libgdata libzapojit gnome3.nautilus gnome3.nautilus-python gnome3.pomodoro shotwell gnome3.totem tracker-miners gnomeExtensions.gsconnect hal-flash irccloud jitsi-meet-electron joplin-desktop ledger-live-desktop libblockdev libndctl marktext mate.mate-utils minetime newsboat notable pantheon.elementary-calendar pantheon.elementary-greeter pantheon.elementary-session-settings pantheon.extra-elementary-contracts pantheon.wingpanel-indicator-datetime pantheon.wingpanel-with-indicators pmdk psensor rapid-photo-downloader ripcord ripgrep ripgrep-all runwayml soulseekqt spaceFM ssb-patchwork standardnotes station styx tusk udiskie udisks unityhub usermount vifm-full weechat weechat-unwrapped wootility wsjtx xfce.gigolo xfce.gvfs xfce.thunar xfce.thunar-archive-plugin xfce.thunar-dropbox-plugin xfce.xfdesktop xmonad_log_applet zulip

almanah fails without this commit
rabbitvcs is marked as broken

  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • used to be 337247856 is now 337247576
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@evils
Copy link
Member Author

evils commented May 12, 2020 •
edited

ping maintainers @yacinehmito @nicknovitski since the bot hasn't done so

yacinehmito
yacinehmito approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@yacinehmito yacinehmito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess they removed the executable.
If it's not working right now this change won't make it worse anyway. Also, one can access safe mode with the --safe argument anyway.
:shipit:

@evils evils mentioned this pull request May 15, 2020
Closed
10 tasks
@evils evils changed the base branch from master to staging May 15, 2020 13:07
@doronbehar doronbehar merged commit 3d36d46 into NixOS:master Sep 19, 2020
@evils evils deleted the asciidoctor branch September 20, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yacinehmito yacinehmito yacinehmito approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@evils @bqv @yacinehmito @doronbehar