Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: solvespace/solvespace
base: 771086fa5050
Choose a base ref
...
head repository: solvespace/solvespace
compare: c1cd315d45e3
Choose a head ref
  • 1 commit
  • 5 files changed
  • 1 contributor

Commits on May 12, 2020

  1. Rename our isnan() function to IsReasonable(). 

    Commit ea6db67 added an unusual isnan macro:

Commit 8bc322e adds a preprocessor guard that looks like it would
cause the isnan function from math.h to be preferred, but doesn't
actually do that on many platforms, e.g. glibc:

This commit renames our isnan() to make it clear that it differs
from the standard library operation, and makes it a function.

Fixes #603.
    @whitequark
    whitequark committed May 12, 2020
    Copy the full SHA
    c1cd315 View commit details
    Browse the repository at this point in the history