Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.dotnetcore2: 2.1.13 -> 2.1.14 #87697

Merged
merged 1 commit into from
May 12, 2020
Merged

python3Packages.dotnetcore2: 2.1.13 -> 2.1.14 #87697

merged 1 commit into from
May 12, 2020
+10 −6

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented May 12, 2020 •
edited
Loading

Motivation for this change

Was having some issues with it.

Tested it locally using a ML user scenario.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@jonringer jonringer requested a review from FRidh as a code owner May 12, 2020 19:37
@jonringer
Copy link
Contributor Author

jonringer commented May 12, 2020 •
edited
Loading

I may move this into my NUR, don't think a lot of people are going to use it, but since I actively maintain it, not sure if there's too much harm of it staying in nixpkgs

main use case for this package is with Azure ML, which is pretty niche.

@ofborg ofborg bot added 6.topic: python 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 12, 2020
@jonringer jonringer merged commit 59c9713 into NixOS:master May 12, 2020
@jonringer jonringer deleted the bump-dotnetcore2-2.1.14 branch August 15, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer