Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the-way: init at 0.3.2 #87710

Merged
merged 4 commits into from Jun 19, 2020
Merged

the-way: init at 0.3.2 #87710

merged 4 commits into from Jun 19, 2020

Conversation

numkem
Copy link
Contributor

@numkem numkem commented May 13, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Gaelan
Copy link
Contributor

Gaelan commented May 15, 2020

Don't forget to add this to all-packages.nix :)

@numkem
Copy link
Contributor Author

numkem commented Jun 7, 2020

@jonringer I've fixed the tests so they are running correctly and updated the package to use version 0.3.2 instead of 0.2.3.

numkem and others added 2 commits June 18, 2020 11:24
Co-authored-by: Lassulus <github@lassul.us>
Co-authored-by: Lassulus <github@lassul.us>
@numkem numkem requested a review from Lassulus June 18, 2020 21:09
@Lassulus Lassulus merged commit 5a345d6 into NixOS:master Jun 19, 2020
@numkem numkem deleted the the-way branch June 19, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants