Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap pkg-config #87705

Merged
merged 3 commits into from May 16, 2020
Merged

Wrap pkg-config #87705

merged 3 commits into from May 16, 2020

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Fix #86077

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 changed the title Wrap pkg config Wrap pkg-config May 12, 2020
@Ericson2314 Ericson2314 force-pushed the wrap-pkg-config branch 6 times, most recently from 99fb295 to 7581c8a Compare May 15, 2020 18:44
@Ericson2314
Copy link
Member Author

The LLVM test's dep's failure is unrelated, and the gcc one past locally.

@Ericson2314 Ericson2314 merged commit 75c55c4 into NixOS:staging May 16, 2020
@Ericson2314 Ericson2314 deleted the wrap-pkg-config branch May 16, 2020 01:00
@Gaelan Gaelan mentioned this pull request May 16, 2020
Closed
@mmilata mmilata mentioned this pull request May 18, 2020
Closed
10 tasks
@matthewbauer matthewbauer mentioned this pull request May 26, 2020
Closed
@FRidh
Copy link
Member

FRidh commented May 29, 2020

Discussion regarding failure on staging #89170

FRidh added a commit that referenced this pull request May 29, 2020
@FRidh
python.pkgs.pkgconfig: fix setup hook
7fe7839 
after regression caused by #87705
@samueldr samueldr mentioned this pull request Jun 5, 2020
Merged
10 tasks
@FRidh
Copy link
Member

FRidh commented Jun 6, 2020

Cross-compilation failure is now blocking staging-next #89388 (comment).

@Izorkin Izorkin mentioned this pull request Jun 13, 2020
Closed
@matthewbauer matthewbauer mentioned this pull request Jun 25, 2020
Merged
@flokli flokli mentioned this pull request Jul 22, 2020
Closed
@pbogdan pbogdan mentioned this pull request Aug 16, 2020
Closed
@gustavderdrache gustavderdrache mentioned this pull request Dec 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @FRidh @matthewbauer