Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kexectools: always pass host and target to configure #87690

Merged
merged 1 commit into from May 12, 2020
Merged

kexectools: always pass host and target to configure #87690

merged 1 commit into from May 12, 2020

Conversation

Gaelan
Copy link
Contributor

@Gaelan Gaelan commented May 12, 2020

Motivation for this change

Fixes #56290.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Gaelan
Copy link
Contributor Author

Gaelan commented May 12, 2020

Gulp, didn't realize how much depended on this. Lemme rebase to staging

@Gaelan Gaelan changed the base branch from master to staging May 12, 2020 19:17
@Gaelan
Copy link
Contributor Author

Gaelan commented May 12, 2020

Alright, on staging now. Sorry for the spurious review requests!

@Mic92
Copy link
Member

Mic92 commented May 12, 2020

@GrahamcOfBorg build kexectools

@Mic92 Mic92 merged commit b9a81f7 into NixOS:staging May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kexec-tools arch purity problem
3 participants
@Gaelan @Mic92 @jonringer