Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visidata: add darwin to supported platforms #87692

Merged
merged 1 commit into from May 13, 2020
Merged

visidata: add darwin to supported platforms #87692

merged 1 commit into from May 13, 2020

Conversation

badmutex
Copy link
Contributor

@badmutex badmutex commented May 12, 2020 •
edited

Motivation for this change

I've been using visidata on darwin for a while and haven't run into issues.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels May 12, 2020
@ofborg ofborg bot requested a review from 7c6f434c May 12, 2020 19:12
@badmutex badmutex changed the title visidata: add darwin to supported flatforms visidata: add darwin to supported platforms May 12, 2020
@7c6f434c 7c6f434c merged commit a1f68b7 into NixOS:master May 13, 2020
@badmutex badmutex deleted the patch-1 branch May 13, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@badmutex @7c6f434c