Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

routinator: 0.7.0 -> 0.7.1 #90476

Merged
merged 1 commit into from Jun 18, 2020
Merged

routinator: 0.7.0 -> 0.7.1 #90476

merged 1 commit into from Jun 18, 2020

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Jun 15, 2020

Motivation for this change

Upgrade to 0.7.1 ‘Moonlight and Love Songs’.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

Result of nixpkgs-review pr 90476 1

1 package built:
- routinator

mweinelt
mweinelt approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by doing local validation runs. LGTM. Thanks for taking caring of routing stuff! ❤️

@Lassulus Lassulus merged commit 46405e7 into NixOS:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0x4A6F @mweinelt @Lassulus