Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: ccfa6b3eee9f
Choose a base ref
...
head repository: NixOS/nix
compare: a588b6b19d93
Choose a head ref
  • 6 commits
  • 4 files changed
  • 1 contributor

Commits on Jun 15, 2020

  1. Remove unnecessary amDone() overrides

    @edolstra
    edolstra committed Jun 15, 2020
    Copy the full SHA
    3170773 View commit details
    Browse the repository at this point in the history

  2. Always hide the progress bar on exit

    @edolstra
    edolstra committed Jun 15, 2020
    Copy the full SHA
    4e995bc View commit details
    Browse the repository at this point in the history

  3. Cleanup

    @edolstra
    edolstra committed Jun 15, 2020
    Copy the full SHA
    f20bb98 View commit details
    Browse the repository at this point in the history

  4. Respect terminal width printing error messages

    @edolstra
    edolstra committed Jun 15, 2020
    Copy the full SHA
    8b09981 View commit details
    Browse the repository at this point in the history

  5. Include only the base name of the program in error messages

    @edolstra
    edolstra committed Jun 15, 2020
    Copy the full SHA
    24a3208 View commit details
    Browse the repository at this point in the history

  6. Print only one error message if a build fails 

    E.g. instead of

  error: --- BuildError ----------------------------------------------- nix
  builder for '/nix/store/03nk0a3n8h2948k4lqfgnnmym7knkcma-foo.drv' failed with exit code 1
  error: --- Error ---------------------------------------------------- nix
  build of '/nix/store/03nk0a3n8h2948k4lqfgnnmym7knkcma-foo.drv' failed

we now get

  error: --- Error ---------------------------------------------------- nix
  builder for '/nix/store/03nk0a3n8h2948k4lqfgnnmym7knkcma-foo.drv' failed with exit code 1
    @edolstra
    edolstra committed Jun 15, 2020
    Copy the full SHA
    a588b6b View commit details
    Browse the repository at this point in the history