Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luaPackages.ldbus: init at scm-0 #90542

Merged
merged 1 commit into from Jun 17, 2020
Merged

luaPackages.ldbus: init at scm-0 #90542

merged 1 commit into from Jun 17, 2020

Conversation

Pablo1107
Copy link
Contributor

Motivation for this change

This adds ldbus, a Lua library to use dbus. Note that the last version is 3 years old, but it's used by some AwesomeWM widgets, so it might be useful to have.

I use it for a bluetooth widget on awesome and it works well.

Related issue: #90532
cc @teto

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: lua label Jun 15, 2020
teto
teto requested changes Jun 15, 2020
View reviewed changes
pkgs/development/lua-modules/overrides.nix Outdated Show resolved Hide resolved
@teto
Copy link
Member

teto commented Jun 16, 2020

when there is a server set, luarocks-nix shouldn't use a mirror. I don't remember if I already fixed it or not but while waiting for an update, you could fix the url manually and use http://luarocks.org/dev/ldbus-scm-0.rockspec instead of mirror:///

@Pablo1107
Copy link
Contributor Author

when there is a server set, luarocks-nix shouldn't use a mirror. I don't remember if I already fixed it or not but while waiting for an update, you could fix the url manually and use http://luarocks.org/dev/ldbus-scm-0.rockspec instead of mirror:///

Ok, a thing to notice is that the rockspec seems to be downloadable in luarocks.org and luarocks.org/dev as well. Idk why Luarocks asks to specify that server.

@teto teto merged commit 52c9061 into NixOS:master Jun 17, 2020
@Pablo1107 Pablo1107 deleted the ldbus-scm-0 branch June 17, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto requested changes

Assignees
No one assigned
Labels
6.topic: lua 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pablo1107 @teto