Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fwupd: 1.4.2 -> 1.4.4 #90539

Merged
merged 2 commits into from Jun 16, 2020
Merged

fwupd: 1.4.2 -> 1.4.4 #90539

merged 2 commits into from Jun 16, 2020

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/fwupd/versions.

meta.description for fwupd is: ""

meta.homepage for fwupd is: "https://fwupd.org/"

meta.changelog for fwupd is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
116 total rebuild path(s)

40 package rebuild(s)

40 x86_64-linux rebuild(s)
31 i686-linux rebuild(s)
18 x86_64-darwin rebuild(s)
27 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
amarok
amarok-kf5
clementine
clementineUnfree
consul
delve
discover
dnscontrol
ergo
fwupd
gauge
gnome-firmware-updater
gnome3.gnome-software
grepm
keycard-cli
kodiPlugins.steam-launcher
libdap
liblastfm
librealsense
lutris
minishift
mutt
mutt-with-sidebar
onedrive
picard-tools
plasma5.discover
pueue
qbec
rmlint
skaffold
steam
steam-run
steamcmd
tests.nixos-functions.nixos-test
tfsec
topgrade
trompeloeil
video2midi
vimPlugins.vim-go
wayvnc
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/b691cjkic7s445qlp9qmvsf88h10bll9-fwupd-1.4.4 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A fwupd https://github.com/r-ryantm/nixpkgs/archive/bfa1712590b2875dc921eb3273f303f206c1b3e2.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/b691cjkic7s445qlp9qmvsf88h10bll9-fwupd-1.4.4
ls -la /nix/store/b691cjkic7s445qlp9qmvsf88h10bll9-fwupd-1.4.4/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

4 packages built:
- discover
- fwupd
- gnome-firmware-updater
- gnome3.gnome-software

Maintainer pings

cc @jtojnar for testing.

We need to keep the passthru.filesInstalledToEtc and passthru.defaultBlacklistedPlugins in sync with the package contents so let's add a test to enforce that.
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay:

Also added a test for checking consistency of the passthru attributes and that passes as well.

@ofborg ofborg bot requested a review from jtojnar June 16, 2020 09:38
@jtojnar jtojnar merged commit 7c20a53 into NixOS:master Jun 16, 2020
@r-ryantm r-ryantm deleted the auto-update/fwupd branch July 1, 2020 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants