WIP: Use std::string_view everywhere #3698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, libutils builds
|
Looks good to me! |
|
OK everything builds (!), but there are some bugs I need to work out. I will also find myself some extra feedback on style/idioms. |
|
I think this should wait for Rust haha :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an optimization I couldn't care less about
const std::string &vsstd:string_view. However,std:string_viewmatches Rust's&str, which is used far more than&String, so I figure this is good for FFI, which is more likely to be worth it.Still, this is a real slog so I'll not keep working on it unless told this is wanted.