Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move search from navigation bar to learn page #472

Merged
merged 2 commits into from Jun 16, 2020
Merged

move search from navigation bar to learn page #472

merged 2 commits into from Jun 16, 2020

Conversation

garbas
Copy link
Member

@garbas garbas commented Jun 15, 2020

fixes #457

@garbas garbas requested a review from samueldr June 15, 2020 11:52
@github-actions
Copy link
Contributor

@edolstra
Copy link
Member

I'm not so sure about this. The only reason I visit nixos.org is for the options/package search...

@davidak
Copy link
Member

davidak commented Jun 15, 2020

same

we have the links in the footer and package search on the start page. maybe add options search to a section about nixos (that don't exist yet) on the startpage?

so maybe just remove it from the menu? and put a site search there like people expect

@edolstra
Copy link
Member

I'd keep it in the navbar. You don't want to have to search for the search feature. If we need to save space in the navbar, it could be done like the Red Hat homepage, which has a search icon in the navbar.

@garbas
Copy link
Member Author

garbas commented Jun 16, 2020

I'm going to leave a "search icon" link on the right side (pointing to packages search) just to keep it easier to find. Eventually (any day now) this will point to search.nixos.org where visitor will see that you can search also for nixos options.

@github-actions
Copy link
Contributor

@garbas
Copy link
Member Author

garbas commented Jun 16, 2020

@davidak

we have the links in the footer and package search on the start page. maybe add options search to a section about nixos (that don't exist yet) on the startpage?

I tried and it doesn't look good since it complicated things. There is a link to options search.

so maybe just remove it from the menu? and put a site search there like people expect

I don't think site search adds value since everybody is already using their own preferred search engine.

@chrissound
Copy link

I think moving it at the bottom isn't ideal for discover-ability. The whole reason I even knew about the options search is because it was on the front page navigation (otherwise I assumed one just browses the nix source code to figure things out).

Possibly we could link the options search on the package search page? That could also help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search "actions" in header can't be used on narrow viewports
4 participants