New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging next #90447
Merged
Merged
Staging next #90447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
python3.pkgs.jedi: remove unused postPatch
python2Packages: default to dontUsePythonRecompileBytecode = true;
For Python 3.8 jsonschema 3.2.0 is required instead of 2.6.0.
There are too many regressions. Instead of reverting all the work that has been done on this so far, let's just disable it Python-wide. That way we can investigate and fix it easier.
I looking forward to see this merged soon. Many things are broken in master. |
Pretty sure many other things will be broken once this lands ;) |
However tail dependencies are easier to fix since. Currently I have to rebuild firefox to get a working desktop... |
Half the packages are still building but there aren't any significant regressions I could see except for the expected Python 2 breakage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)