Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging next #90447

Merged
merged 632 commits into from Jun 19, 2020
Merged

Staging next #90447

merged 632 commits into from Jun 19, 2020

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jun 15, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Mic92 and others added 7 commits June 17, 2020 02:06
python3.pkgs.jedi: remove unused postPatch
python2Packages: default to dontUsePythonRecompileBytecode = true;
For Python 3.8 jsonschema 3.2.0 is required instead of 2.6.0.
There are too many regressions. Instead of reverting all the work that has been
done on this so far, let's just disable it Python-wide. That way we can
investigate and fix it easier.
@Mic92
Copy link
Member

Mic92 commented Jun 18, 2020

I looking forward to see this merged soon. Many things are broken in master.

@FRidh
Copy link
Member Author

FRidh commented Jun 18, 2020

Pretty sure many other things will be broken once this lands ;)

@Mic92
Copy link
Member

Mic92 commented Jun 18, 2020

However tail dependencies are easier to fix since. Currently I have to rebuild firefox to get a working desktop...

@flokli
Copy link
Contributor

flokli commented Jun 18, 2020

Yeah, I also heard some reports about boto3 and botocore being broken in master. Looking forward to see this merged aswell.

@FRidh FRidh merged commit 58d569d into master Jun 19, 2020
@FRidh
Copy link
Member Author

FRidh commented Jun 19, 2020

Half the packages are still building but there aren't any significant regressions I could see except for the expected Python 2 breakage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet