Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factorio{,-headless}-experimental: 0.18.30 -> 0.18.32 #90499

Merged
merged 1 commit into from Jun 18, 2020
Merged

factorio{,-headless}-experimental: 0.18.30 -> 0.18.32 #90499

merged 1 commit into from Jun 18, 2020

Conversation

priegger
Copy link
Contributor

@priegger priegger commented Jun 15, 2020 •
edited

Motivation for this change

Update to latest experimental factorio version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from erictapen, Baughn and elitak June 15, 2020 14:54
@priegger
Copy link
Contributor Author

0.18.32 was released. I'll update the PR.

@ofborg ofborg bot requested a review from Baughn June 17, 2020 08:47
@priegger priegger changed the title factorio{,-headless}-experimental: 0.18.30 -> 0.18.31 factorio{,-headless}-experimental: 0.18.30 -> 0.18.32 Jun 17, 2020
erictapen
erictapen approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds for me.

@NickHu
Copy link
Contributor

NickHu commented Jun 18, 2020

Thanks again! I'm personally getting lots of mileage out of your continued contribution 😁

@NickHu NickHu merged commit 3690f94 into NixOS:master Jun 18, 2020
@priegger priegger deleted the fix/factorio-experimental branch June 22, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erictapen erictapen erictapen approved these changes

@elitak elitak Awaiting requested review from elitak

@Baughn Baughn Awaiting requested review from Baughn

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@priegger @NickHu @Baughn @erictapen