Use flake-compat without fetchGit #1372
Conversation
This fixes 2 different issues: 1. Github actions Checkout does a shallow clone by default. We want to use a shallow clone but force a deep clone because builtins.fetchGit doesn't seem to work on shallow clones. 2. It doesn't work when this repo is a store path and .git is removed.
| sha256 = "1n8q7v7alq802kl3b6zan6v27whi2ppbnlv8df6cz64vqf658ija"; }) { | ||
| src = builtins.fetchGit ./.; | ||
| }).defaultNix | ||
| { pkgs ? import <nixpkgs> {} }: |
There was a problem hiding this comment.
Making default.nix and shell.nix depend on <nixpkgs> is a bad idea. 1) It's inefficient, since now evaluation requires at least 2 versions of Nixpkgs. 2) It goes against the whole point of flakes, which is hermetic evaluation. It reintroduces a dependency on $NIX_PATH which is what we want to get rid of.
|
I don't understand the motivation. Why would you need to rebuild everything on every change? That's what nix-shell is for right? |
|
I think this would be better addressed in flake-compat, where we could have some logic to check whether |
|
I've submitted a PR to use |
An alternative approach to #1371 that doesn't force you to rebuild everything on every change.
This fixes 2 different issues:
Github actions Checkout does a shallow clone by default.
We want to use a shallow clone but force a deep clone because
builtins.fetchGit doesn't seem to work on shallow clones.
It doesn't work when this repo is a store path and .git is removed.