Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxsqlite3/wxsqliteplus: use gtk2 variant #90551

Closed
wants to merge 3 commits into from
Closed

wxsqlite3/wxsqliteplus: use gtk2 variant #90551

wants to merge 3 commits into from

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Also, we set the pname for wxGTK3 to include the gtk version. This makes
it a lot clearer when trying to figure out what pulls in a gtk2 dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from vrthra June 16, 2020 02:09
@peterhoeg peterhoeg changed the title wxsqlite3/wxsqliteplus: use gtk3 variant wxsqlite3/wxsqliteplus: use gtk2 variant Jun 16, 2020
@peterhoeg peterhoeg closed this Aug 24, 2020
@peterhoeg peterhoeg deleted the wxgtk_fix branch August 24, 2020 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant