Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bs1770gain: 0.5.2 -> 0.7.0 #90504

Closed
wants to merge 1 commit into from
Closed

bs1770gain: 0.5.2 -> 0.7.0 #90504

wants to merge 1 commit into from

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/bs1770gain/versions.

meta.description for bs1770gain is: "A audio/video loudness scanner implementing ITU-R BS.1770"

meta.homepage for bs1770gain is: "http://bs1770gain.sourceforge.net/"

meta.changelog for bs1770gain is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
Rebuild report (if merged into master) (click to expand) 
7 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
beets
bs1770gain
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/ybqqzs4ngjqnmk0yk1a6s6rrry5anq67-bs1770gain-0.7.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A bs1770gain https://github.com/r-ryantm/nixpkgs/archive/489b8e09f2b4db28cf4be3509d37f49be7a419d5.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/ybqqzs4ngjqnmk0yk1a6s6rrry5anq67-bs1770gain-0.7.0
ls -la /nix/store/ybqqzs4ngjqnmk0yk1a6s6rrry5anq67-bs1770gain-0.7.0/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

1 package failed to build:
- beets
1 package built:
- bs1770gain
Maintainer pings

@r-ryantm r-ryantm closed this Jul 1, 2020
@r-ryantm r-ryantm deleted the auto-update/bs1770gain branch July 1, 2020 04:36
@ryantm ryantm restored the auto-update/bs1770gain branch July 1, 2020 05:09
@ryantm ryantm reopened this Jul 1, 2020
@Lassulus
Copy link
Member

nix-review reports an error for beets:

failed with exit code 1
builder for '/nix/store/h7dardi7s50c7p4v0pqbd3bjvwr1f021-beets-1.4.9.drv' failed with exit code 1; last 10 log lines:
      six.reraise(exc_info[1], None, exc_info[2])
    File "/nix/store/0dgwycx10h6yikb94a2wl32bliglsfdm-python3.8-six-1.15.0/lib/python3.8/site-packages/six.py", line 700, in reraise
      value = tp()
  TypeError: 'UserError' object is not callable
  
  ----------------------------------------------------------------------
  Ran 1901 tests in 65.611s
  
  FAILED (SKIP=29, errors=3)
  builder for '/nix/store/h7dardi7s50c7p4v0pqbd3bjvwr1f021-beets-1.4.9.drv' failed with exit code 1
cannot build derivation '/nix/store/d5fgzljqyrjla0fc6gnblcv44093g174-env.drv': 1 dependencies couldn't be built

@doronbehar doronbehar mentioned this pull request Sep 1, 2020
Closed
@doronbehar
Copy link
Contributor

Indeed. I opened an issue upstream: beetbox/beets#3740

@Lassulus
Copy link
Member

so should we merge this anyway and patch beets later? or wait for the beets fix?

@doronbehar
Copy link
Contributor

I was unable to backport upstream's beetbox/beets#3480 for beets 1.4.9. I think we can't merge this until beets 1.5.0.

@lovesegfault
Copy link
Member

Regardless of any of this, the package is filled with white supremacist hate speech now, and needs to be manually patched to remove that.

Check the source and grep for WHITE, if you want to see the filth. It must be scrubbed and not touch our users' systems.

@Lassulus
Copy link
Member

Lassulus commented Jan 2, 2021 •
edited

huh, thats indeed pretty bonkers,
I would follow other distributions (like termux termux/termux-packages#4455) and remove the package altogether. It doesn't seem to be needed by anything besides beets which seems to have switched to supporting ffmpeg for this functionality.

@doronbehar
Copy link
Contributor

We could also (additionally / instead) package beetsUnstable. There are many bugs and improvements there that are missing from 1.4.9.

@lovesegfault
Copy link
Member

I'm working on packaging beetsUnstable right now. I got it building last night. Once in the tree I will make a PR removing bs1770gain and pruning that functionality from stable beets.

@lovesegfault lovesegfault mentioned this pull request Jan 3, 2021
Merged
10 tasks
doronbehar added a commit to lovesegfault/nixpkgs that referenced this pull request Jan 3, 2021
@lovesegfault @doronbehar
beets: 1.4.9 -> unstable-2020-12-22
0faf72a 
The maintainer has stopped cutting releases[1]. Since the last release,
1.4.9, includes a dependency that is filled with hate speech[2] it's all
the more reason to package the unstable version and eliminate that
requirement.

Moreover a number of fixes, improvements, and features have landed
since.

[1]: beetbox/beets#3625
[2]: NixOS#90504

Co-authored-by: Doron Behar <doron.behar@gmail.com>
@lovesegfault
Copy link
Member

bs1770gain has been yanked from the tree. beets now uses ffmpeg for replay gain.

@r-ryantm r-ryantm deleted the auto-update/bs1770gain branch January 3, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: blocked by pr/issue 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@r-ryantm @Lassulus @doronbehar @lovesegfault @ryantm @SuperSandro2000