Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mising #include for strerror #3699

Merged
merged 1 commit into from Jun 16, 2020

Conversation

Ericson2314
Copy link
Member

[I think we're overdue for some CI that always ensures the merge builds too.]

@Ericson2314
Copy link
Member Author

Ericson2314 commented Jun 16, 2020

@gilligan looks like I unbroke the build itself, but the unit tests need fixing.

@gilligan
Copy link
Contributor

@Ericson2314 oh that's too bad. i'll have a look at it and also ping @bburdette

@gilligan
Copy link
Contributor

[I think we're overdue for some CI that always ensures the merge builds too.]

I think this can either be changed in the GitHub actions config or PRs could be required to be up to date with master for merge.

@domenkozar changing the github actions config to also run tests on the PR merged into master shouldn't be too hard I guess?

@gilligan
Copy link
Contributor

Had a quick look at it. The tests were broken by 8b09981 which was pushed directly to master so no change to CI is going to help in this case.

@gilligan
Copy link
Contributor

@Ericson2314 gilligan@4dae6eb this fixes the unit tests

@gilligan gilligan mentioned this pull request Jun 16, 2020
@domenkozar domenkozar merged commit 7e7e3b7 into NixOS:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants