Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i3pystatus: 2019-06-10 -> 2020-07-14; fix desktop notifications #90456

Merged
merged 2 commits into from Jun 17, 2020
Merged

i3pystatus: 2019-06-10 -> 2020-07-14; fix desktop notifications #90456

merged 2 commits into from Jun 17, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 15, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from igsha June 15, 2020 08:54
igsha
igsha suggested changes Jun 16, 2020
View reviewed changes
pkgs/applications/window-managers/i3/pystatus.nix Show resolved Hide resolved
pkgs/applications/window-managers/i3/pystatus.nix Outdated Show resolved Hide resolved
pkgs/applications/window-managers/i3/pystatus.nix Outdated Show resolved Hide resolved
pkgs/applications/window-managers/i3/pystatus.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from igsha June 16, 2020 06:54
@Mic92 Mic92 merged commit 62c02ec into NixOS:master Jun 17, 2020
@Mic92 Mic92 deleted the i3pystatus branch June 17, 2020 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igsha igsha igsha requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @igsha