Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clamav: enable build on darwin #90463

Merged
merged 1 commit into from Jun 23, 2020
Merged

clamav: enable build on darwin #90463

merged 1 commit into from Jun 23, 2020

Conversation

mroi
Copy link
Contributor

@mroi mroi commented Jun 15, 2020

This rather simple change allows to build ClamAV on Darwin. I made tests on Darwin with the on-demand scanner and things appear to be working.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels Jun 15, 2020
@ofborg ofborg bot requested review from Phreedom, fpletz, globin and qknight June 15, 2020 10:40
@LnL7 LnL7 merged commit 70084e8 into NixOS:master Jun 23, 2020
@mroi mroi deleted the patch-clamav branch June 28, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

@Phreedom Phreedom Awaiting requested review from Phreedom

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

@qknight qknight Awaiting requested review from qknight

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mroi @LnL7