Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgcc: fix Darwin cross compile #90506

Merged
merged 1 commit into from Jun 15, 2020
Merged

libgcc: fix Darwin cross compile #90506

merged 1 commit into from Jun 15, 2020

Conversation

mroi
Copy link
Contributor

@mroi mroi commented Jun 15, 2020

I guess this is a fallout from the build variables reorganisation in 1ac5398: the previous infix notation was changed to a suffix notation.

With this patch, Linux versions of libgcc can be cross compiled on Darwin hosts again. Compilation on Linux still works.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

late fallout from 1ac5398: the build variables were changed from infix to suffix notation
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Jun 15, 2020
@matthewbauer matthewbauer merged commit 834272d into NixOS:master Jun 15, 2020
@matthewbauer
Copy link
Member

Thanks!

@Ericson2314
Copy link
Member

Thanks! Sorry I missed this grepping;

@mroi mroi deleted the patch-libgcc branch June 16, 2020 11:48
@mroi
Copy link
Contributor Author

mroi commented Jun 16, 2020

Filed under open-source benefits: crowd-sourced grepping. ;)
It was fun diagnosing this down to such an obvious fix. Thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants