Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impy,evilpixie: init #90515

Merged
merged 2 commits into from Jun 20, 2020
Merged

impy,evilpixie: init #90515

merged 2 commits into from Jun 20, 2020

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jun 15, 2020 •
edited

Motivation for this change

Cool pixel-oriented image editor. We're missing those.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fgaz
Copy link
Member Author

fgaz commented Jun 18, 2020

/marvin opt-in

@marvin-mk2 marvin-mk2 bot added the marvin label Jun 18, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Jun 18, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. The stages are

  • needs_review, if the author considers this PR ready
  • needs_work if the PR in its current form is not ready yet. Maybe the reviewer requested changes, there is an ongoing discussion or you are waiting for upstream feedback.
  • needs_merge can be set by reviewers who do not have merge permission but would merge this PR if they could.

Anybody can switch the current status with a comment of the form /status <new_status_here>.

Feedback and contributions to this bot are appreciated.

@fgaz
Copy link
Member Author

fgaz commented Jun 18, 2020

/status needs_review

@symphorien
Copy link
Member

Ran nix-review, executed evilpixie in an empty PATH, checked that the open dialog does not crash, checked that the icon of the desktop file is found in rofi, saved an image successfully.

/marvin needs_merge

@symphorien
Copy link
Member

/status needs_merge

@marvin-mk2 marvin-mk2 bot requested a review from timokau June 20, 2020 12:55
@timokau
Copy link
Member

timokau commented Jun 20, 2020

Thanks @fgaz @symphorien. I couldn't find a single nit to pick and the review is great. Really nothing to do for me except pressing the merge button. Keep up the good work :)

@timokau timokau merged commit 40178ea into NixOS:master Jun 20, 2020
@fgaz fgaz deleted the evilpixie/init branch June 21, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien approved these changes

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fgaz @symphorien @timokau