Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deno: 1.0.5 -> 1.1.0 #90460

Merged
merged 2 commits into from Jun 16, 2020
Merged

deno: 1.0.5 -> 1.1.0 #90460

merged 2 commits into from Jun 16, 2020

Conversation

06kellyjac
Copy link
Member

Motivation for this change

Upgrade deno to 1.1.0

Fix dependency issue in update script

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@06kellyjac
deno: 1.0.5 -> 1.1.0
10bf0f2
@06kellyjac
deno: fix update script dependency
5adbf9a 
nix-prefetch-url comes with nix and isn't a package on it's own
@06kellyjac 06kellyjac changed the title Deno 1.1.0 deno: 1.0.5 -> 1.1.0 Jun 15, 2020
@marsam marsam merged commit 4d975b1 into NixOS:master Jun 16, 2020
@06kellyjac
Copy link
Member Author

It's already got aarch64_linux down under platforms:
https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/web/deno/default.nix#L80

Does aarch64 on android use a different double?
https://github.com/nixos/nixpkgs/blob/master/lib/systems/doubles.nix

Feel free to give it a try & let me know how it goes. Or maybe I'll be able to have a go in the next couple of days.

@06kellyjac 06kellyjac deleted the deno_1.1.0 branch July 25, 2020 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@06kellyjac @marsam