config.public.json: add trailing slash to doc #515
Conversation
There was a problem hiding this comment.
SGTM for now, but I believe this will still trigger on bumps for packages e.g. scdoc (pkgs/tools/typesetting/sc**doc/**default.nix). It'll definitely cut down on false-positives, but at some point we might want to rework the parsing of these paths -- wherever that occurs -- to incorporate FRidh's suggestion from the linked issue (namely: "It should do the matching from the start of the [path]").
|
Perhaps we should also change this to absolute paths relative to the git checkout. |
|
Changed to Seems matrix won't let me log in today so I can't comment there or |
| @@ -255,7 +255,7 @@ impl PathsTagger { | |||
| .possible | |||
| .iter() | |||
| .filter(|&(ref tag, ref _paths)| !self.selected.contains(&tag)) | |||
| .filter(|&(ref _tag, ref paths)| paths.iter().any(|tp| path.contains(tp))) | |||
| .filter(|&(ref _tag, ref paths)| paths.iter().any(|tp| path.starts_with(tp))) | |||
There was a problem hiding this comment.
I don't actually know if the path is only something like pkgs/applications/... or if it also includes the checkout (e.g. ~/workspace/vcs/nixpkgs in my case).
@LnL7 since you run the darwin builder, do you know/can you verify if this is or isn't the case? (I still haven't taken the time to setup my own builder to play around with stuff like this... I'll do that Soon™.)
If it does start with the checkout path, we'll want to strip that out/not care about it before starts_with will work as expected.
Might help with #148?
I went through the last few pages of PRs with this label and it looks evenly split between PRs that have docs and not.