Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pycurl: Exclude flaky multi_timer_test #90481

Merged
merged 1 commit into from Jun 15, 2020
Merged

pycurl: Exclude flaky multi_timer_test #90481

merged 1 commit into from Jun 15, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Jun 15, 2020

Motivation for this change

Fixes #77304 (comment).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I've tested it on top of 20.03.

CC @maralorn @florianjacob @jonringer

@nh2 nh2 requested review from FRidh and jonringer as code owners June 15, 2020 13:13
This was referenced Jun 15, 2020
Closed
Merged
jonringer
jonringer approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 90481 1

2 packages marked as broken and skipped:
- python27Packages.koji
- python27Packages.osc
24 packages built:
- pyCA
- python27Packages.blivet
- python27Packages.nixpart
- python27Packages.nixpart0
- python27Packages.pycurl
- python27Packages.pykickstart
- python27Packages.urlgrabber
- python27Packages.wfuzz
- python37Packages.bugwarrior
- python37Packages.nvchecker
- python37Packages.osc
- python37Packages.patator
- python37Packages.pycurl
- python37Packages.urlgrabber
- python37Packages.wfuzz
- python38Packages.bugwarrior
- python38Packages.nvchecker
- python38Packages.osc
- python38Packages.patator
- python38Packages.pycurl
- python38Packages.urlgrabber
- wfuzz (python38Packages.wfuzz)
- system-config-printer
- udocker

@jonringer jonringer merged commit ab1ae10 into NixOS:master Jun 15, 2020
@nh2 nh2 mentioned this pull request Jun 15, 2020
Merged
10 tasks
@nh2
Copy link
Contributor Author

nh2 commented Jun 15, 2020

20.03 backport PR: #90543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.7 pycurl build failing in latest unstable
2 participants
@nh2 @jonringer