Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.CryptMySQL: fix darwin build #90512

Merged
merged 1 commit into from Jun 17, 2020
Merged

perlPackages.CryptMySQL: fix darwin build #90512

merged 1 commit into from Jun 17, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Jun 15, 2020

Sets LD=$CC which fixes Error: no compiler detected to compile... error on darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 labels Jun 15, 2020
@aanderse
Copy link
Member

@GrahamcOfBorg build perlPackages.CryptMySQL
@GrahamcOfBorg build perldevelPackages.CryptMySQL

@aanderse
Copy link
Member

Not that I know anything about darwin... but if @stigtsp says "good to go" we're good to go 👍

@aanderse aanderse merged commit 63d375f into NixOS:master Jun 17, 2020
@stigtsp
Copy link
Member Author

stigtsp commented Jun 17, 2020

Good to go :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stigtsp @aanderse