Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kmail: add missing dependency (kdepim-addons) #90511

Merged
merged 1 commit into from Jul 13, 2020

Conversation

pjones
Copy link
Contributor

@pjones pjones commented Jun 15, 2020

Motivation for this change

The kdepim-addons dependency is needed in KMail to add many of the
standard plug-ins, including the "External Editor" plug-in.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The `kdepim-addons` dependency is needed in KMail to add many of the
standard plug-ins, including the "External Editor" plug-in.
@pwetzel
Copy link
Contributor

pwetzel commented Jun 18, 2020

These work if you just put kdeApplications.kdepim-addons in environment.systemPackages, or at least that's why I think they work for me on 20.03 as it is? Maybe that shouldn't be necessary. Not sure anyone running kmail cares about an extra 11MiB in plugins.

Getting all of KDE installed has been something of a mystery to me. It seems like I shouldn't have to put kdeApplications.* in environment.systemPackages, but that's the only answer I've seen.

@vandenoever
Copy link
Contributor

I've not got any kde applications in environment.systemPackages. I just install them with nix-env. The only global KDE setting I have is services.xserver.desktopManager.plasma5.enable = true;. This is in NixOS 20.03.

@ttuegel ttuegel merged commit b8e3f27 into NixOS:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants