Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tremor location fix #90464

Merged
merged 1 commit into from Jul 2, 2020
Merged

Tremor location fix #90464

merged 1 commit into from Jul 2, 2020

Conversation

fomichevmi
Copy link
Contributor

@fomichevmi fomichevmi commented Jun 15, 2020 •
edited

Tremor is not available any longer via 'https://git.xiph.org/tremor.git'.

Motivation for this change

Tremor is not accessible via https://git.xiph.org/tremor.git

Things done

Outdated git location replaced with actual

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fomichevmi fomichevmi closed this Jun 15, 2020
@fomichevmi fomichevmi reopened this Jun 15, 2020
puzzlewolf
puzzlewolf suggested changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@puzzlewolf puzzlewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first PR! 🎉

As the repository for Tremor is now hosted on gitlab, I think it would be preferable to use fetchFromGitLab instead of the generic fetchgit. Do you feel up for changing that?

Also, when you're done: Please squash your commits into one, with a commit message matching CONTRIBUTING.md.

@fomichevmi fomichevmi changed the title Tremor location fix Draft: Tremor location fix Jun 15, 2020
@fomichevmi fomichevmi force-pushed the patch-1 branch 2 times, most recently from f691e1e to ca6bbdf Compare June 15, 2020 17:11
@fomichevmi fomichevmi changed the title Draft: Tremor location fix Tremor location fix Jun 16, 2020
@fomichevmi
Copy link
Contributor Author

Thanks for your first PR! 🎉

As the repository for Tremor is now hosted on gitlab, I think it would be preferable to use fetchFromGitLab instead of the generic fetchgit. Do you feel up for changing that?

Also, when you're done: Please squash your commits into one, with a commit message matching CONTRIBUTING.md.

I think, it's ready

@puzzlewolf
Copy link
Contributor

This PR causes a lot of rebuilds, see tags added by @GrahamcOfBorg. It should be made against the staging branch (see manual).

Ideally, you can just change the base branch in the github interface for this PR.

@FRidh FRidh merged commit 0a9d994 into NixOS:master Jul 2, 2020
@FRidh
Copy link
Member

FRidh commented Jul 2, 2020

ah, indeed, should have gone to staging. Oh well, it's not too bad in this case.

@puzzlewolf
Copy link
Contributor

@FRidh What number of rebuilds would you consider a rough threshold for targeting staging instead of master? The manual speaks of "mass rebuilds", but isn't clear what that is xD. Maybe when the tag goes red, i.e. 501+?

@FRidh
Copy link
Member

FRidh commented Jul 2, 2020

Yes, we draw the line at 500.

@nickfraser nickfraser mentioned this pull request Dec 27, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puzzlewolf puzzlewolf puzzlewolf requested changes

@DzmitrySudnik DzmitrySudnik DzmitrySudnik approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+ 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fomichevmi @puzzlewolf @FRidh @DzmitrySudnik @Janik-Haag