Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arb: 2.17.0 -> 2.18.0 #90466

Closed
wants to merge 1 commit into from
Closed

arb: 2.17.0 -> 2.18.0 #90466

wants to merge 1 commit into from

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/arb/versions.

meta.description for arb is: "A library for arbitrary-precision interval arithmetic"

meta.homepage for arb is: "http://arblib.org/"

meta.changelog for arb is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
Rebuild report (if merged into master) (click to expand) 
6 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
arb
sage
sageWithDoc
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/158kc1a36c2jwi8859155wgmlab58mmj-arb-2.18.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A arb https://github.com/r-ryantm/nixpkgs/archive/577e63091db71d7edda1b34c84d03c2afdefffbc.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/158kc1a36c2jwi8859155wgmlab58mmj-arb-2.18.0
ls -la /nix/store/158kc1a36c2jwi8859155wgmlab58mmj-arb-2.18.0/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

2 packages failed to build:
- sage (sagemath)
- sageWithDoc
1 package built:
- arb
Maintainer pings

cc @7c6f434c @timokau for testing.

@ofborg ofborg bot requested review from timokau and 7c6f434c June 15, 2020 11:03
@timokau timokau marked this pull request as draft June 15, 2020 19:51
@timokau
Copy link
Member

timokau commented Jun 15, 2020

Some adjustments to the sage testsuite necessary.

@timokau timokau added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Jun 15, 2020
@timokau
Copy link
Member

timokau commented Jun 15, 2020

https://trac.sagemath.org/ticket/28623#comment:9

@r-ryantm r-ryantm closed this Jul 1, 2020
@r-ryantm r-ryantm deleted the auto-update/arb branch July 1, 2020 04:35
@ryantm ryantm restored the auto-update/arb branch July 1, 2020 05:10
@ryantm ryantm reopened this Jul 1, 2020
@stale
Copy link

stale bot commented Dec 28, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 28, 2020
@r-ryantm r-ryantm deleted the auto-update/arb branch January 18, 2021 05:06
@timokau
Copy link
Member

timokau commented Jan 18, 2021 •
edited

The latest sage master now supports/requires arb 2.18.1. I'm taking a step back from sage maintenance, so I will not work on the update.

CC @omasanori and @collares in case either of you plans to work on the next sage update.

@omasanori
Copy link
Contributor

@timokau Ack. Thank you for letting us know.
Now SageMath 9.3 is in beta stage and I expect rc1 would be suitable for starting actual upgrade effort.

@timokau
Copy link
Member

timokau commented Jan 20, 2021

Related: #109890

The way I have always kept it is to

  1. update sage dependencies when upstream support is available, backporting patches to sage if necessary.
  2. keep a WIP PR in which I track the intermediate sage releases.

The reason for (1) is that it simplifies the actual update (ideally we only need to update the sage source and remove most of the patches) and does not block the dependencies. The downside is that sage in nixpkgs might deviate slightly from upstream sage, which could introduce bugs or be confusing for a user.

The reason for (2) is again that it simplifies the update process. Instead of having to fix all the breakage that the update introduces at once, the work can be split over a longer time and multiple commits. Nix specific regressions can be reported/fixed during the beta phase. By the time the new release is official, the update is already almost finished. Having intermediate commits for the beta releases can also help when trying to pin down regressions with git-bisect.

That's just my process though. It has its upsides and its downsides. If you want to tackle the next update, whatever works best for you is good :)

@omasanori
Copy link
Contributor

Thank you for your explanation, @timokau! That makes sense. I will try 2.18.1 first then, as 2.19 (latest) is not known to work with SageMath.

@timokau
Copy link
Member

timokau commented Feb 2, 2021

Okay, feel free to ping me if you need a review. If you end up trying 2.19 you could open an upstream trac ticket and report your results there. If you encounter packaging specific issues, the sage-packaging mailing list may also be able to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau Awaiting requested review from timokau

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: wait-for-upstream Waiting for upstream fix (or their other action). 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@r-ryantm @timokau @omasanori @ryantm @SuperSandro2000