Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skaffold: 1.9.1 -> 1.10.1 #89291

Merged
merged 1 commit into from Jun 4, 2020
Merged

skaffold: 1.9.1 -> 1.10.1 #89291

merged 1 commit into from Jun 4, 2020

Conversation

dsyer
Copy link
Contributor

@dsyer dsyer commented Jun 1, 2020

There's a bug in 1.9.1 where skaffold debug adds a spurious args: "" to the deployment manifest. It was fixed in 1.10. Supersedes #87826 (can someone please tell me what to do to get these merged?).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dsyer
skaffold: 1.9.1 -> 1.10.1
f7651f7 
There's a bug in 1.9.1 where `skaffold debug` adds a spurious `args: ""` to the deployment manifest. It was fixed in 1.10.
@ofborg ofborg bot requested a review from vdemeester June 1, 2020 09:03
vdemeester
vdemeester approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@bhipple
Copy link
Contributor

bhipple commented Jun 4, 2020

Result of nixpkgs-review pr 89291 1

1 package built:
- skaffold

@bhipple bhipple merged commit 2068c82 into NixOS:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dsyer @bhipple @vdemeester