Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "fb notify" quirk, fixing motorola-addison touch with boot GUI #154

Merged
merged 2 commits into from May 31, 2020

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented May 31, 2020

Quite simply, motorola-addison's touch input will not work if the display has not been properly "awakened".

Touching .../blank ends up causing fb_notifier_call_chain to be called, which ends up causing rmi4_data->panel_nb.notifier_call to be called, causing synaptics_dsx_panel_cb to be called. This, finally, puts the touch panel active. (grep the vendor kernel tree for those names.)


X11 touch input was working fine. It must be doing things just right to wake up the framebuffer. LVGL does not, which means the boot GUI did not work.

This quirk touches the `blank` file of the framebuffer /sys nodes, which
ends up unsuspending things that start suspended until the *right thing*
is happening to not be suspended.

X11, among others, do the right things. It seems other framebuffer
interfaces are not.

This can likely be fixed in other ways, but this is the more
approachable way to me right now.
@samueldr samueldr added the 4. type: bug Something isn't working label May 31, 2020
@samueldr samueldr changed the title Add "fb notify" quirk, fixing motorola-addison touch Add "fb notify" quirk, fixing motorola-addison touch with boot GUI May 31, 2020
@samueldr samueldr merged commit 340213c into NixOS:master May 31, 2020
@samueldr samueldr deleted the fix/motorola-addison-touch branch May 31, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant