Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tuptime: 4.1.0 -> 5.0.0 #89235

Merged
merged 2 commits into from Jun 20, 2020
Merged

tuptime: 4.1.0 -> 5.0.0 #89235

merged 2 commits into from Jun 20, 2020

Conversation

evils
Copy link
Member

@evils evils commented May 31, 2020 •
edited

Motivation for this change

a new major version was released

Notes

the database format has changed, though it seems it keeps working without manual intervention
it either converted the database by itself, or it can parse the old version as well
a script to update the database format is included, this adds the sqlite dependency

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • was 106428288, is 107888720 (increased due to adding sqlite to the database update script?)
  • Ensured that relevant documentation is up to date
    • this package/module isn't in 20.03 so no release note about the database change is required?
  • Fits CONTRIBUTING.md.

@evils
Copy link
Member Author

evils commented Jun 19, 2020 •
edited

/marvin opt-in

@marvin-mk2
Copy link

marvin-mk2 bot commented Jun 19, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin label Jun 19, 2020
timokau
timokau requested changes Jun 19, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some clarifications needed.

nixos/modules/services/monitoring/tuptime.nix Outdated Show resolved Hide resolved
pkgs/tools/system/tuptime/default.nix Outdated Show resolved Hide resolved
pkgs/tools/system/tuptime/default.nix Outdated Show resolved Hide resolved
@timokau
Copy link
Member

timokau commented Jun 19, 2020

/status needs_work

@evils
Copy link
Member Author

evils commented Jun 19, 2020

/status needs_review

@evils
tuptime: 4.1.0 -> 5.0.0
1dca47c 
uptimed import script removed from source ("unreliable")
new database format, including migration script instead
@evils
nixos/tuptime: change group/user to match upstream
73a90b0
@Mic92 Mic92 merged commit 7c945cb into NixOS:master Jun 20, 2020
@timokau
Copy link
Member

timokau commented Jun 20, 2020

Thanks!

@marvin-mk2 marvin-mk2 bot requested a review from timokau July 3, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
6.topic: nixos 8.has: clean-up 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evils @timokau @Mic92