Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for lru-cache.hh #3644

Merged
merged 2 commits into from Jun 2, 2020
Merged

Add tests for lru-cache.hh #3644

merged 2 commits into from Jun 2, 2020

Conversation

gilligan
Copy link
Contributor

Simple set of tests for a simple lru cache data structure ;)

@gilligan gilligan mentioned this pull request May 30, 2020
16 tasks
Copy link
Contributor

@jbit jbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Gill 😄
I saw your tweet and was bored, so I took a look through as a curious NixOS user.
I couldn't see anything immediately wrong, but you never tested the result of erase, which you might want to do?

src/libutil/tests/lru-cache.cc Outdated Show resolved Hide resolved
src/libutil/tests/lru-cache.cc Outdated Show resolved Hide resolved
src/libutil/tests/lru-cache.cc Outdated Show resolved Hide resolved
Co-authored-by: James Lee <jbit@jbit.net>
@edolstra edolstra merged commit c16fdda into NixOS:master Jun 2, 2020
@gilligan
Copy link
Contributor Author

gilligan commented Jun 2, 2020

Thanks for the review @jbit and thanks for fixing & merging @edolstra - i didn’t have the time to address those right away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants