New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
agda: install literate files #89245
agda: install literate files #89245
Conversation
Would it be better to manually list the different extensions for literate agda files ( |
How about having an option for a list of extension to search for, and append that to a conservative whitelist? As example value, you can then give |
There are already quite a few options and I think the list I have put in now should cover everything for now |
It would be very easy to add, I am more worried about making the documentation not confusing |
I suppose a line could be put in saying these can be overriden by an |
It's just a hunch that it might be useful to leave this configurable. Sometimes a new markdown format pops up, and people start using it before these settings are adjusted. For example in Haskell it's annoying that literate programming in |
I have added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great. Just some whitespace issues I probably introduced.
Thanks for the catches |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
not sure if this is a regression:
|
@Lassulus those two packages were already broken as they have not been updated to work with (/ do not have a release for) |
Just for the record, this broke the nixpkgs manual, fix is in #90689. |
Motivation for this change
New agda builder did not copy over literate agda files (https://agda.readthedocs.io/en/v2.6.1/tools/literate-programming.html). None of the libraries seem to use these which is why we didn't see this issue but I don't see a reason not to support them.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)cc @turion
@GrahamcOfBorg test agda