Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnuradio: 3.7.13.4 -> 3.7.14.0 #89244

Merged
merged 1 commit into from May 31, 2020
Merged

gnuradio: 3.7.13.4 -> 3.7.14.0 #89244

merged 1 commit into from May 31, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented May 31, 2020 •
edited

Motivation for this change

#82263

Update to a compatible version without introducing breaking changes that will brake packages. (Reduce the scope of #84401 ).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from fpletz and bjornfor May 31, 2020 09:08
@doronbehar
Copy link
Contributor Author

doronbehar commented May 31, 2020 •
edited

ofborg reported these attributes as affected.

@GrahamcOfBorg build gr-limesdr
@GrahamcOfBorg build inspectrum
@GrahamcOfBorg build gr-nacl
@GrahamcOfBorg build gr-rds
@GrahamcOfBorg build gnss-sdr
@GrahamcOfBorg build gr-gsm
@GrahamcOfBorg build gr-ais
@GrahamcOfBorg build gnuradio
@GrahamcOfBorg build qradiolink
@GrahamcOfBorg build gnuradio-with-packages
@GrahamcOfBorg build gqrx
@GrahamcOfBorg build gr-osmosdr

@doronbehar
Copy link
Contributor Author

@flokli here's the PR bumping GNU Radio to 3.7.14.0 which is the compatible version from upstream's 3.7 branch.

@doronbehar doronbehar marked this pull request as ready for review May 31, 2020 09:37
@doronbehar
Copy link
Contributor Author

I've checked using @GrahamcOfBorg build that all attributes that are affected by this change succeed to compile.

@flokli flokli merged commit 1c170f9 into NixOS:master May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@bjornfor bjornfor Awaiting requested review from bjornfor

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doronbehar @flokli