Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hplip: don't reference gcc in binaries from /share and other locations #89265

Merged
merged 1 commit into from Jun 6, 2020
Merged

hplip: don't reference gcc in binaries from /share and other locations #89265

merged 1 commit into from Jun 6, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented May 31, 2020 •
edited

Motivation for this change

Make hplip packages not reference gcc-unwrapped,

Things done

Removed reference of all hplip variants to gcc-unwrapped. It was mostly easy with a stripDebugList attribute, but for the default hplip removeReferencesTo was needed.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar doronbehar marked this pull request as draft May 31, 2020 20:43
@ofborg ofborg bot requested review from ttuegel and jgeerds May 31, 2020 20:50
@doronbehar doronbehar marked this pull request as ready for review June 1, 2020 21:00
@doronbehar doronbehar force-pushed the hplip-gcc-references branch 2 times, most recently from c91243c to eb48576 Compare June 3, 2020 16:52
@ttuegel ttuegel merged commit d1f62c5 into NixOS:master Jun 6, 2020
@ttuegel
Copy link
Member

ttuegel commented Jun 6, 2020

Thanks!

@doronbehar doronbehar mentioned this pull request Jul 12, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

@jgeerds jgeerds Awaiting requested review from jgeerds

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doronbehar @ttuegel