Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpvScripts.simple-mpv-webui: init at 1.0.0 #89262

Merged
merged 2 commits into from Jun 17, 2020
Merged

Conversation

cript0nauta
Copy link
Contributor

@cript0nauta cript0nauta commented May 31, 2020

Motivation for this change

Adding the simple-mpv-webui mpv plugin and fix #88584

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

samba support will be dropped in mpv upstream in its next release (see
mpv-player/mpv@3b8b7cb).
Also, using it triggered segmentation faults when using luasocket.

Closes NixOS#88584
@doronbehar
Copy link
Contributor

Also, if instead of:

fixing #88584

You'd use:

fix #88584

That issue will be closed automatically upon merge of this PR.

@cript0nauta
Copy link
Contributor Author

Also, if instead of:

fixing #88584

You'd use:

fix #88584

That issue will be closed automatically upon merge of this PR.

I put Closes #88584 in the commit message so this should close the issue once this is merged.

@doronbehar
Copy link
Contributor

I put Closes #88584 in the commit message so this should close the issue once this is merged.

Hmm, I guess you are right but GitHub doesn't pick this to the "Linked issues" section at the right bar of the PR...

@cript0nauta
Copy link
Contributor Author

Hmm, I guess you are right but GitHub doesn't pick this to the "Linked issues" section at the right bar of the PR...

Oh ok, I updated the description now as you suggested.

Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works and it's pretty cool. Thanks!

@Ma27 Ma27 merged commit 0a63b5a into NixOS:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mpv crashes with scripts using luasocket
3 participants