New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mpvScripts.simple-mpv-webui: init at 1.0.0 #89262
Conversation
samba support will be dropped in mpv upstream in its next release (see mpv-player/mpv@3b8b7cb). Also, using it triggered segmentation faults when using luasocket. Closes NixOS#88584
ca16a7c
to
9ca525e
Compare
Hmm, I guess you are right but GitHub doesn't pick this to the "Linked issues" section at the right bar of the PR... |
9ca525e
to
5930a0e
Compare
Oh ok, I updated the description now as you suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works and it's pretty cool. Thanks!
Motivation for this change
Adding the simple-mpv-webui mpv plugin and fix #88584
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)