Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python39: fix build on macOS #89252

Merged
merged 1 commit into from Jun 4, 2020
Merged

python39: fix build on macOS #89252

merged 1 commit into from Jun 4, 2020

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented May 31, 2020

Motivation for this change

Python 3.9.0a4 doesn't currently compile on macOS. This PR fixes this.
I basically made the same changes as in 81d1594 but for python3.9 instead of python3.8.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Luflosi
python39: fix build on macOS
bec0a35 
Basically the same changes as in 81d1594 but for python3.9 instead of python3.8.
@Luflosi Luflosi requested a review from FRidh as a code owner May 31, 2020 15:21
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: python labels May 31, 2020
@FRidh
Copy link
Member

FRidh commented May 31, 2020

@GrahamcOfBorg build python39

@Luflosi
Copy link
Contributor Author

Luflosi commented Jun 4, 2020

@FRidh Could you please review when you have some time?

@FRidh FRidh merged commit 2379e36 into NixOS:master Jun 4, 2020
@Luflosi Luflosi deleted the python-darwin branch June 4, 2020 15:12
@Luflosi
Copy link
Contributor Author

Luflosi commented Jun 4, 2020

Thank you ❤️.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Luflosi @FRidh