Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utf8cpp: init at 3.1.1 #89276

Merged
merged 2 commits into from Jun 21, 2020
Merged

utf8cpp: init at 3.1.1 #89276

merged 2 commits into from Jun 21, 2020

Conversation

jobojeha
Copy link
Member

Motivation for this change

Adds UTF8-CPP, a simple, portable and lightweight generic library for handling UTF-8 encoded strings. Required as a dependency for ParaView > 5.7.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

IvarWithoutBones
IvarWithoutBones requested changes Jun 1, 2020
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor nits, otherwise LGTM

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/development/libraries/utf8cpp/default.nix Outdated Show resolved Hide resolved
@IvarWithoutBones
Copy link
Member

IvarWithoutBones commented Jun 1, 2020 •
edited

Oh, 1 more thing: 2240aab and 5e82fc8 should be squashed together.

@jobojeha
Copy link
Member Author

jobojeha commented Jun 1, 2020

Thanks for the review! 😄 Updated to your suggestions.

IvarWithoutBones
IvarWithoutBones approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

danieldk
danieldk reviewed Jun 21, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this derivation! Looks good to me 👍 , though I wondered why tests are disabled. They seem to work well and might catch future regressions.

Diff for enabling tests: https://gist.github.com/danieldk/88c0b97819b3c009aaee32be004a69a4

danieldk
danieldk approved these changes Jun 21, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for enabling the tests! LGTM.

Result of nixpkgs-review pr 89276 1

1 package built:
- utf8cpp

@danieldk danieldk merged commit 30adb1f into NixOS:master Jun 21, 2020
@jobojeha
Copy link
Member Author

@danieldk Oh yes thats perfect. Thanks for your proposed changes! 😄 I pushed them now. I originally disabled tests because I looked into the build instructions over in the Arch PKGBUILD and with enabled tests it wasn't recognized by paraview as a dependency at first. I forgot about the doChecks, so I guess thats why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@IvarWithoutBones IvarWithoutBones IvarWithoutBones approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jobojeha @IvarWithoutBones @danieldk