Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 1607e821ff22
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 03147cf7ae53
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on May 31, 2020

  1. libversion: Fix unsafe concatenation of $LD_LIBRARY_PATH 

    Naive concatenation of $LD_LIBRARY_PATH can result in an empty
colon-delimited segment; this tells glibc to load libraries from the
current directory, which is definitely wrong, and may be a security
vulnerability if the current directory is untrusted.  This particular
case probably has no security relevance, but we should avoid this
unsafe pattern anyway in case it gets copied.  See #76804.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
    @andersk
    andersk committed May 31, 2020
    Copy the full SHA
    665dfc2 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #89243 from andersk/libversion-LD_LIBRARY_PATH 

    libversion: Fix unsafe concatenation of $LD_LIBRARY_PATH
    @ryantm
    ryantm committed May 31, 2020
    Copy the full SHA
    03147cf View commit details
    Browse the repository at this point in the history