ATS2: add support for Darwin platform with a GCC toolchain #89283

avanov · 2020-06-01T02:40:58Z

Motivation for this change

Current master branch doesn't contain a derivation for the current stable ATS2 (0.4.0), and MacOS is exempt from supported platforms

Things done

ATS2 version is upgraded to 0.4.0
ATS2-Contrib and ATS2 tarballs have appropriate sha256 checksums
metadata now contains platforms.darwin - this is possible through explicit passing of gccStdenv to the derivation on Darwin.
as I use Jetbrains' IDEs heavily, a corresponding gitignore entry was added.

avanov · 2020-12-09T23:38:49Z

I've rebased the branch. The gcc stdenv is needed for this reason (output from an attempt to build with the default stdenv on macos big sur, I wonder why the make expects gcc, seems like a hardcoded value in the build script of the distribution? make -j4 -C src/CBOOT patsopt CCOMP=gcc GCFLAG= LDFLAGS=):

these derivations will be built:
  /nix/store/cq5d00rhyycycrhizrk78g0sa69qmq36-ats2-0.4.1.drv
building '/nix/store/cq5d00rhyycycrhizrk78g0sa69qmq36-ats2-0.4.1.drv'...
unpacking sources
unpacking source archive /nix/store/4l1r96ilp1icnly1gnc77hx4y1qz32xj-ATS2-Postiats-gmp-0.4.1.tgz
source root is ATS2-Postiats-gmp-0.4.1
setting SOURCE_DATE_EPOCH to timestamp 1596421339 of file ATS2-Postiats-gmp-0.4.1/utils/myatscc/node_modules/atscntrb-hx-parcomb/package.json
patching sources
configuring
configure flags: --prefix=/nix/store/na64byw8hdal3yhl554wd65dmnvvv8hj-ats2-0.4.1
checking for gcc... clang
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether clang accepts -g... yes
checking for clang option to accept ISO C89... none needed
checking for a BSD-compatible install... /nix/store/nx7ppsj5gimsar4v1hxzsbzyvyl1w5js-coreutils-8.32/bin/install -c
checking for a thread-safe mkdir -p... /nix/store/nx7ppsj5gimsar4v1hxzsbzyvyl1w5js-coreutils-8.32/bin/mkdir -p
checking whether ln -s works... yes
checking how to run the C preprocessor... clang -E
checking for grep that handles long lines and -e... /nix/store/xybak912ykzhd2myns1vpziyaq7v66lw-gnugrep-3.6/bin/grep
checking for egrep... /nix/store/xybak912ykzhd2myns1vpziyaq7v66lw-gnugrep-3.6/bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking gmp.h usability... yes
checking gmp.h presence... yes
checking for gmp.h... yes
checking size of void*... 8
checking for posix_memalign... yes
checking for memalign... no
configure: creating ./config.status
config.status: creating config.mk
config.status: creating bin/patscc_env.sh
config.status: creating bin/myatscc_env.sh
config.status: creating bin/patsopt_env.sh
config.status: creating config.h
building
build flags: SHELL=/nix/store/pmmh1dl7kmxi2xpagknl9qqa4wr7vv9c-bash-4.4-p23/bin/bash
\
make -j4 -C src/CBOOT patsopt \
CCOMP=gcc GCFLAG= LDFLAGS= 
make[1]: Entering directory '/private/var/folders/7s/_k9r0mwd15b4pr4h78v5x2km0000gn/T/nix-build-ats2-0.4.1.drv-0/ATS2-Postiats-gmp-0.4.1/src/CBOOT'
gcc -O2 -I. -I./ccomp/runtime -c -o pats_main_dats.o pats_main_dats.c
gcc -O2 -I. -I./ccomp/runtime -c -o pats_error_sats.o pats_error_sats.c
gcc -O2 -I. -I./ccomp/runtime -c -o pats_intinf_sats.o pats_intinf_sats.c
gcc -O2 -I. -I./ccomp/runtime -c -o pats_counter_sats.o pats_counter_sats.c
/nix/store/pmmh1dl7kmxi2xpagknl9qqa4wr7vv9c-bash-4.4-p23/bin/bash: gcc: command not found
make[1]: *** [Makefile:352: pats_main_dats.o] Error 127
make[1]: *** Waiting for unfinished jobs....
/nix/store/pmmh1dl7kmxi2xpagknl9qqa4wr7vv9c-bash-4.4-p23/bin/bash: gcc: command not found
make[1]: *** [Makefile:351: pats_error_sats.o] Error 127
/nix/store/pmmh1dl7kmxi2xpagknl9qqa4wr7vv9c-bash-4.4-p23/bin/bash: gcc: command not found
make[1]: *** [Makefile:351: pats_intinf_sats.o] Error 127
/nix/store/pmmh1dl7kmxi2xpagknl9qqa4wr7vv9c-bash-4.4-p23/bin/bash: gcc: command not found
make[1]: *** [Makefile:351: pats_counter_sats.o] Error 127
make[1]: Leaving directory '/private/var/folders/7s/_k9r0mwd15b4pr4h78v5x2km0000gn/T/nix-build-ats2-0.4.1.drv-0/ATS2-Postiats-gmp-0.4.1/src/CBOOT'
make: *** [Makefile:79: src2_patsopt] Error 2
builder for '/nix/store/cq5d00rhyycycrhizrk78g0sa69qmq36-ats2-0.4.1.drv' failed with exit code 2
error: build of '/nix/store/cq5d00rhyycycrhizrk78g0sa69qmq36-ats2-0.4.1.drv' failed

With the gcc stdenv the build succeeds:

$ which patscc
/nix/store/bla85ask8zcrnygv95hw67z2wsryqr8w-ats2-0.4.1/bin/patscc

$ patscc
ATS/Postiats version 0.4.1 with Copyright (c) 2011-2020 Hongwei Xi

raboof

would be nice to avoid that direct dependency on gcc (can we create a PR/issue about that upstream and reference it here?), but that can be a future improvement - LGTM!

avanov · 2020-12-12T21:53:00Z

I've filed a ticket on ATS2 repository (the link), however I'm not sure if that's the only location where GCC is hardcoded.

avanov · 2020-12-12T21:54:48Z

@thoughtpolice @ttuegel @bbarker is there anything else that needs to be done before we could merge this PR? I'm happy to wait for a patch for 0.4.2 if there's a known release date.

ttuegel · 2020-12-12T22:15:47Z

It looks like upstream has some suggestion about how to build with Clang? Let's see if that works, it would be nice to use the platform-native stdenv where it can be supported.

@avanov I don't really use ATS lately, but as far as I'm concerned, you can add yourself to the maintainers if you would like.

avanov · 2020-12-13T15:27:08Z

let's wait until githwxi/ATS-Postiats#258 is done, and then we could test both 0.4.2 and the native stdenv.

SuperSandro2000 · 2021-03-21T04:11:47Z

maintainers/maintainer-list.nix

@@ -842,6 +842,12 @@
    githubId = 354741;
    name = "Austin Butler";
  };
+  avanov = {


Please put this into a separate commit with the message maintainers: add avanov.

SuperSandro2000 · 2021-03-21T04:11:58Z

pkgs/development/compilers/ats2/default.nix

@@ -51,7 +51,7 @@ stdenv.mkDerivation rec {
    description = "Functional programming language with dependent types";
    homepage    = "http://www.ats-lang.org";
    license     = licenses.gpl3Plus;
-    platforms   = platforms.linux;
-    maintainers = with maintainers; [ thoughtpolice ttuegel bbarker ];
+    platforms   = platforms.linux ++ platforms.darwin;


Suggested change

platforms = platforms.linux ++ platforms.darwin;

platforms = platforms.unix;

stale · 2021-11-09T19:20:29Z

I marked this as stale due to inactivity. → More info

thiagokokada · 2023-01-08T14:55:18Z

Closed by #208750.

ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 1, 2020

avanov changed the base branch from master to nixpkgs-unstable June 1, 2020 02:43

avanov changed the base branch from nixpkgs-unstable to master June 1, 2020 02:43

ofborg bot added 6.topic: haskell 6.topic: nixos 6.topic: python 8.has: documentation 8.has: module (update) 8.has: package (new) and removed 6.topic: haskell 6.topic: nixos 6.topic: python 8.has: documentation 8.has: module (update) labels Jun 1, 2020

ofborg bot requested review from bbarker, thoughtpolice and ttuegel June 1, 2020 02:48

ofborg bot requested a review from ttuegel December 9, 2020 23:09

ofborg bot added 10.rebuild-linux: 0 and removed 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Dec 9, 2020

avanov requested a review from raboof December 9, 2020 23:34

avanov force-pushed the ATS2-0.4.0-darwin branch from 5691adf to baa6d46 Compare December 9, 2020 23:48

raboof approved these changes Dec 10, 2020

View reviewed changes

avanov mentioned this pull request Dec 12, 2020

GCC toolchain is hardcoded in distribution makefile githwxi/ATS-Postiats#259

Closed

avanov force-pushed the ATS2-0.4.0-darwin branch from baa6d46 to 0dcb827 Compare February 18, 2021 14:10

ofborg bot added 11.by: package-maintainer 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-linux: 0 labels Feb 18, 2021

SuperSandro2000 requested changes Mar 21, 2021

View reviewed changes

ATS2: add support for Darwin platform (GCC toolchain)

35bb5cc

avanov force-pushed the ATS2-0.4.0-darwin branch from 0dcb827 to 35bb5cc Compare May 6, 2021 19:32

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 9, 2021

Artturin added the 12.approvals: 1 label Apr 13, 2022

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 13, 2022

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 2, 2022

wegank mentioned this pull request Jan 2, 2023

ats2: add darwin support #208750

Merged

13 tasks

thiagokokada closed this Jan 8, 2023

Janik-Haag added the 12. first-time contribution label Jun 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ATS2: add support for Darwin platform with a GCC toolchain #89283

ATS2: add support for Darwin platform with a GCC toolchain #89283

avanov commented Jun 1, 2020 •

edited

avanov commented Dec 9, 2020 •

edited

raboof left a comment

avanov commented Dec 12, 2020

avanov commented Dec 12, 2020

ttuegel commented Dec 12, 2020

avanov commented Dec 13, 2020

SuperSandro2000 Mar 21, 2021

SuperSandro2000 Mar 21, 2021

stale bot commented Nov 9, 2021

thiagokokada commented Jan 8, 2023

	platforms = platforms.linux ++ platforms.darwin;
	platforms = platforms.unix;

ATS2: add support for Darwin platform with a GCC toolchain #89283

ATS2: add support for Darwin platform with a GCC toolchain #89283

Conversation

avanov commented Jun 1, 2020 • edited

Motivation for this change

Things done

avanov commented Dec 9, 2020 • edited

raboof left a comment

Choose a reason for hiding this comment

avanov commented Dec 12, 2020

avanov commented Dec 12, 2020

ttuegel commented Dec 12, 2020

avanov commented Dec 13, 2020

SuperSandro2000 Mar 21, 2021

Choose a reason for hiding this comment

SuperSandro2000 Mar 21, 2021

Choose a reason for hiding this comment

stale bot commented Nov 9, 2021

thiagokokada commented Jan 8, 2023

avanov commented Jun 1, 2020 •

edited

avanov commented Dec 9, 2020 •

edited