Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamlink-twitch-gui-bin: init at 1.10.0 #89282

Merged
merged 1 commit into from Aug 22, 2020

Conversation

rileyinman
Copy link
Contributor

Motivation for this change

I wanted to be able to use streamlink-twitch-gui, and it doesn't seem anyone else has taken a crack at packaging it. I tried getting the yarn build to work but kept running into problems, as I'm not that experienced with yarn or the node ecosystem on NixOS. Repackaging the binary seems to work fine though. With help from the developer, it even correctly runs with the streamlink wrapper script out of the box starting with version 1.10.0!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rileyinman
Copy link
Contributor Author

Updated to fix a typo.

@Lassulus
Copy link
Member

cool, can you squash the changes into the first commit?

@rileyinman
Copy link
Contributor Author

Of course!

@Lassulus Lassulus merged commit 05c92dc into NixOS:master Aug 22, 2020
@rileyinman
Copy link
Contributor Author

Thank you :D

@rileyinman rileyinman deleted the streamlink-twitch-gui branch August 23, 2020 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants