streamlink-twitch-gui-bin: init at 1.10.0 #89282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I wanted to be able to use streamlink-twitch-gui, and it doesn't seem anyone else has taken a crack at packaging it. I tried getting the yarn build to work but kept running into problems, as I'm not that experienced with yarn or the node ecosystem on NixOS. Repackaging the binary seems to work fine though. With help from the developer, it even correctly runs with the streamlink wrapper script out of the box starting with version 1.10.0!
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)